Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code maintenance/46647 bump rails to 7.1 #14440

Merged
merged 97 commits into from
Feb 1, 2024
Merged

Code maintenance/46647 bump rails to 7.1 #14440

merged 97 commits into from
Feb 1, 2024

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Dec 18, 2023

@dombesz dombesz force-pushed the code-maintenance/46647-bump-rails-to-71 branch 5 times, most recently from 5252a80 to 546d98f Compare December 21, 2023 10:48
aaron-contreras
aaron-contreras reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@aaron-contreras aaron-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I believe the specs are failing because using Rails.application.credentials now expects to find these secrets in a credentials.yml file instead of a secrets.yml.

@dombesz dombesz force-pushed the code-maintenance/46647-bump-rails-to-71 branch 5 times, most recently from 81c0a90 to 42d6652 Compare January 10, 2024 12:55
@dombesz dombesz force-pushed the code-maintenance/46647-bump-rails-to-71 branch 10 times, most recently from aa5af8e to 06190ac Compare January 17, 2024 15:54
@dombesz dombesz force-pushed the code-maintenance/46647-bump-rails-to-71 branch 3 times, most recently from b0101c5 to 26d7cb4 Compare January 25, 2024 15:15
@dombesz dombesz force-pushed the code-maintenance/46647-bump-rails-to-71 branch from 1eac79d to 7dfb8bd Compare January 27, 2024 09:23
cbliard and others added 24 commits February 1, 2024 14:23
@cbliard @dombesz
flaky-fix: Wait for ng-select list to refresh after entering text
2f10bd4 
Without that, we could click on a stale option and stuck the test.
@dombesz
Cache classes and remove null cache store config.
4ca1d09
@dombesz
Lock the rails version to 7.1.3
c9d7735
@dombesz
Correct the config.enable_reloading setting in the test environment
2468cc9
@dombesz
Cache Principal.default scope to reduce the number of queries on the …
f2fb7f6 
…Capabilities.default scope.
@dombesz
Cache principal query directly in the capabilities scope
c354528
@dombesz
Fix and simplify the update_cost_repor_spec
79c0466
@dombesz
Use the filter loaded expectation on hidden elements for mobile view.
0f8f9f1
@dombesz
Re-use work package filter loaded expectation
ceac4eb
@dombesz
Revert "Fix move work package specs by fixing the context menu opening"
08e4fce 
This reverts commit bdd2aaf.
@dombesz
Make the WorkPacakge::Filters#expect_loaded method to work for mobile…
10c5d2f 
… view as well
@dombesz
Address CR comments
1f39137
@dombesz
Change Board page expect_card to wait for reloading the board column
49b314e
@dombesz
Attempt to wait a bit longer for flaky spec
fa1d124
@dombesz
Lock rails version to 7.1.x that is above 7.1.3
7830645
@dombesz
Fix typos
ac98e83
@dombesz
Use the expect_and_dismiss_toaster method in work package table specs.
8e63311
@dombesz @aaron-contreras
Remove typo comment
bf15e20 
Co-authored-by: Aaron Contreras <[email protected]>
@dombesz
Lock rails version to ~>7.1.3
fb77503
@dombesz
Use RequestStore fetch, fix typos in Gemfile.
b84d7a1
@dombesz
Remove unnecessary path loading config. Fix module naming for Constra…
8555eb6 
…ints::Enterprise.
@dombesz
Revert create user api to use authSource for backwards compatibility.
eb7fa7f
@dombesz
Simplify default_breadcrumb method
9865cc7
@dombesz
Use DIR instead of FileUtils in bin/setup script
41cef95
@dombesz dombesz requested a review from toy February 1, 2024 12:41
toy
toy approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@toy toy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I can tell

@dombesz dombesz merged commit 99cdf37 into dev Feb 1, 2024
9 checks passed
@dombesz dombesz deleted the code-maintenance/46647-bump-rails-to-71 branch February 1, 2024 13:01
@aaron-contreras
Copy link
Contributor

Awesome job my friend! @dombesz

@klaustopher klaustopher mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-contreras aaron-contreras aaron-contreras approved these changes

@toy toy toy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dombesz @aaron-contreras @toy @oliverguenther @cbliard